Comments on: Fennec added to l10n dashboard http://blog.mozilla.com/axel/2009/02/27/fennec-added-to-l10n-dashboard/ Free your mind and your ass will follow. Tue, 07 Feb 2012 10:14:33 +0000 hourly 1 http://wordpress.org/?v=3.2.1 By: sethb http://blog.mozilla.com/axel/2009/02/27/fennec-added-to-l10n-dashboard/comment-page-1/#comment-1490 sethb Fri, 27 Feb 2009 23:16:36 +0000 http://blog.mozilla.com/axel/?p=139#comment-1490 Yeah, that's all clear. I can see how the structure changed based on your description above. Thanks. Yeah, that’s all clear. I can see how the structure changed based on your description above. Thanks.

]]> By: Axel Hecht http://blog.mozilla.com/axel/2009/02/27/fennec-added-to-l10n-dashboard/comment-page-1/#comment-1489 Axel Hecht Fri, 27 Feb 2009 22:13:57 +0000 http://blog.mozilla.com/axel/?p=139#comment-1489 So, there are two occurences of all-locales in the build logic. One is to load the list of all-locales, i.e., we need (for hg) a url to the hg repo. In this case http://hg.mozilla.org/mobile-browser/file/tip/locales/all-locales. The raw-file version of this, but that doesn't display nicely when you click on the link. The main point here is that you're seeing the tail to be locales/all-locales. The second occurence is the AllLocalesWatcher. It's getting all changes to the repos, and if it's seeing the mobile-browser repo, it looks if locales/all-locales was changed. If so, it triggers reload of the above url. The combination of the two keeps an up-to-date list of which locales build this app inside the scheduler, and that list is used to ignore changes to locales that shouldn't be built, and to kick of the right set of locales for nightlies and en-US-triggered builds. Now to the fun part. How do we get the URL? For all other projects I had worked on before, the l10n.ini file was in the directory $(app)/locales/ in the outer-most repo. Either mozilla-central for firefox, or comm-central for thunderbird et al. comm-central does include other repos, but they're all checked out as child directories of comm-central. So when referencing paths from l10n.ini, I could say "go two directories up, and then browser, toolkit, etc" or "go two directories up and then use browser/locales/all-locales". There was already a light tweak required for CVS, which comes with a leading 'mozilla/', but that resolved happily with how I get files from CVS anyway. Now, for mobile, to reference toolkit, I still need to say "go up two, then toolkit, mobile, etc". But if I say "go up two, then locales/all-locales", I end up outside of the mobile-browser repo. Thus, using the same depth for references to modules in a checked out version on disk as well as remote repository location died. Is that any clear? I can't read as much as I typed on this small comment field. So, there are two occurences of all-locales in the build logic. One is to load the list of all-locales, i.e., we need (for hg) a url to the hg repo. In this case http://hg.mozilla.org/mobile-browser/file/tip/locales/all-locales. The raw-file version of this, but that doesn’t display nicely when you click on the link. The main point here is that you’re seeing the tail to be locales/all-locales.

The second occurence is the AllLocalesWatcher. It’s getting all changes to the repos, and if it’s seeing the mobile-browser repo, it looks if locales/all-locales was changed. If so, it triggers reload of the above url.

The combination of the two keeps an up-to-date list of which locales build this app inside the scheduler, and that list is used to ignore changes to locales that shouldn’t be built, and to kick of the right set of locales for nightlies and en-US-triggered builds.

Now to the fun part. How do we get the URL? For all other projects I had worked on before, the l10n.ini file was in the directory $(app)/locales/ in the outer-most repo. Either mozilla-central for firefox, or comm-central for thunderbird et al. comm-central does include other repos, but they’re all checked out as child directories of comm-central. So when referencing paths from l10n.ini, I could say “go two directories up, and then browser, toolkit, etc” or “go two directories up and then use browser/locales/all-locales”.

There was already a light tweak required for CVS, which comes with a leading ‘mozilla/’, but that resolved happily with how I get files from CVS anyway.

Now, for mobile, to reference toolkit, I still need to say “go up two, then toolkit, mobile, etc”. But if I say “go up two, then locales/all-locales”, I end up outside of the mobile-browser repo.

Thus, using the same depth for references to modules in a checked out version on disk as well as remote repository location died.

Is that any clear? I can’t read as much as I typed on this small comment field.

]]> By: seth bindernagel http://blog.mozilla.com/axel/2009/02/27/fennec-added-to-l10n-dashboard/comment-page-1/#comment-1486 seth bindernagel Fri, 27 Feb 2009 18:40:37 +0000 http://blog.mozilla.com/axel/?p=139#comment-1486 Nice post. One quick question you might enjoy explaining: How did the all-locales file actually end up blowing up your logic? Another general set of questions: * What does AllLocalesWatcher pay attention to? * I assume it's the same for Firefox? * And, does AllLocalesWatcher update the all-locales in the master or is that something else? Would love to learn more about this, just out of my own curiosity... This looks like it might have actually been a challenging but fun exercise because a lot of things are starting from the correct point given all you have learned with building and shipping Firefox over the years. Nice post. One quick question you might enjoy explaining:

How did the all-locales file actually end up blowing up your logic?

Another general set of questions:
* What does AllLocalesWatcher pay attention to?
* I assume it’s the same for Firefox?
* And, does AllLocalesWatcher update the all-locales in the master or is that something else?

Would love to learn more about this, just out of my own curiosity…

This looks like it might have actually been a challenging but fun exercise because a lot of things are starting from the correct point given all you have learned with building and shipping Firefox over the years.

]]>