Comments on: Password Manager changes

By: Justin Dolske

Justin Dolske — Mon, 07 May 2007 19:58:16 +0000

CJ: Try the following extension:

https://addons.mozilla.org/en-US/firefox/addon/2848

By: C J Fertitta

C J Fertitta — Mon, 07 May 2007 18:29:19 +0000

Hello, I would like to be able to export passwords and logins to other computers I work on several computers and would like to have the same logins and password auto login ability on each computer. I have to login to some sites and it never ask me to save the logins so I have to retype all the time. it would be nice to move the file form cpu to cpu

Thanks

C J

By: Justin Dolske

Justin Dolske — Sun, 18 Mar 2007 01:32:51 +0000

Slawa: As part of the Password Manager work leading up to Firefox 3, I’ll be looking at trying to clear some of the backlog of existing bugs. I haven’t evaluated those two specific bugs yet, though.

By: Slawa Olhovchenkov

Slawa Olhovchenkov — Thu, 08 Mar 2007 18:57:39 +0000

Any chance to close bugs https://bugzilla.mozilla.org/show_bug.cgi?id=227632 and https://bugzilla.mozilla.org/show_bug.cgi?id=338050?

By: Justin Dolske

Justin Dolske — Tue, 06 Feb 2007 07:46:13 +0000

Ludovic:

The shift to JavaScript is part of a general theme to use JS for browser components (when suitable). Security is one big reason — there are no buffer overflows in JS code.

It also simplifies the code. The Password Manager has a log of interaction with the DOM, which means lots of XPCOM overhead with C++.

For example:

nsresult
nsPasswordManager::FillDocument(nsIDOMDocument* aDomDoc)
{
nsCOMPtr htmlDoc = do_QueryInterface(aDomDoc);

nsCOMPtr forms;
htmlDoc->GetForms(getter_AddRefs(forms));

nsCOMPtr doc = do_QueryInterface(aDomDoc);

nsCAutoString realm;
if (!GetPasswordRealm(doc->GetDocumentURI(), realm))
return NS_OK;
…

In JS, this might look more like:

FillDocument : function (doc) {
var forms = document.forms;
var realm = GetPasswordRealm(document.location);
if (!realm) throw “Oops”
…

By: Ludovic Hirlimann

Ludovic Hirlimann — Tue, 06 Feb 2007 05:55:21 +0000

What are the advantages to move the password manager from C++ to JS ?

By: Robert Accettura

Robert Accettura — Tue, 06 Feb 2007 03:04:56 +0000

I think “Keychain” and “OpenID or CardSpace” are the key words in this post.

Hopefully at a minimum Firefox 3.0 for Mac won’t ship without Keychain. IMHO it’s a big win for the platform to properly integrate.

This is a giant step forward. Hopefully we’ll see some great uses of the new framework.