Comments on: CPP-Aware C++ Rewriting Can Be Fun http://blog.mozilla.com/tglek/2007/07/18/cpp-aware-c-rewriting-can-be-fun/ Just another Blog.mozilla.com weblog Wed, 11 Nov 2009 17:56:44 -0800 http://wordpress.org/?v=2.8.6 hourly 1 By: jorendorff http://blog.mozilla.com/tglek/2007/07/18/cpp-aware-c-rewriting-can-be-fun/comment-page-1/#comment-2332 jorendorff Thu, 19 Jul 2007 15:11:40 +0000 http://blog.mozilla.com/tglek/2007/07/18/cpp-aware-c-rewriting-can-be-fun/#comment-2332 If I introduce badness in a macro in a header file, will I get email for every place it's used? If so, it seems like you really want to run after each check-in and send a single e-mail to the committer if that specific check-in increased any of the counts. (If it sounds expensive: you can optimize away most of the runs. Just run once a day to see if any counts have increased. If they haven't, you can skip running for every check-in that occurred that day.) If I introduce badness in a macro in a header file, will I get email for every place it’s used? If so, it seems like you really want to run after each check-in and send a single e-mail to the committer if that specific check-in increased any of the counts.

(If it sounds expensive: you can optimize away most of the runs. Just run once a day to see if any counts have increased. If they haven’t, you can skip running for every check-in that occurred that day.)

]]> By: Robert O'Callahan http://blog.mozilla.com/tglek/2007/07/18/cpp-aware-c-rewriting-can-be-fun/comment-page-1/#comment-2322 Robert O'Callahan Thu, 19 Jul 2007 10:46:44 +0000 http://blog.mozilla.com/tglek/2007/07/18/cpp-aware-c-rewriting-can-be-fun/#comment-2322 That's awesome! That’s awesome!

]]> By: Perry Lorier http://blog.mozilla.com/tglek/2007/07/18/cpp-aware-c-rewriting-can-be-fun/comment-page-1/#comment-2308 Perry Lorier Thu, 19 Jul 2007 01:11:18 +0000 http://blog.mozilla.com/tglek/2007/07/18/cpp-aware-c-rewriting-can-be-fun/#comment-2308 You could call cvs annotate on the file, and locate the line(s) where problems occur. That will give you the committer and the revision. if the revision is >'n' then email the committer (And perhaps CC: a list somewhere) with the complaint(s), and if it's You could call cvs annotate on the file, and locate the line(s) where problems occur. That will give you the committer and the revision. if the revision is >’n’ then email the committer (And perhaps CC: a list somewhere) with the complaint(s), and if it’s

]]>