Comments on: Static Analysis and Refactoring Tooling Updates http://blog.mozilla.com/tglek/2008/07/09/static-analysis-and-refactoring-tooling-updates/ Just another Blog.mozilla.com weblog Sun, 12 Feb 2012 07:38:09 +0000 hourly 1 http://wordpress.org/?v=3.2.1 By: tglek http://blog.mozilla.com/tglek/2008/07/09/static-analysis-and-refactoring-tooling-updates/comment-page-1/#comment-18160 tglek Thu, 10 Jul 2008 15:20:28 +0000 http://blog.mozilla.com/tglek/?p=70#comment-18160 1) known bug 2) new bug, typically NS_ENSURE_ARG is used for outparams. thanks 3) it's just a default error setting ever since I did the queryinterface rewrite. It's not meant to be used in the final patch. 1) known bug
2) new bug, typically NS_ENSURE_ARG is used for outparams. thanks
3) it’s just a default error setting ever since I did the queryinterface rewrite. It’s not meant to be used in the final patch.

]]> By: Boris http://blog.mozilla.com/tglek/2008/07/09/static-analysis-and-refactoring-tooling-updates/comment-page-1/#comment-18159 Boris Thu, 10 Jul 2008 15:17:36 +0000 http://blog.mozilla.com/tglek/?p=70#comment-18159 Looking at the patch, I have a few questions: 1) How easy would it be to nix the (nsINodeInfo*) casts? They don't seem to be needed... 2) Can we convert the NS_ENSURE_ARG into an NS_ASSERTION instead of just removing it? 3) Why NS_ERROR_NO_INTERFACE? Looking at the patch, I have a few questions:

1) How easy would it be to nix the (nsINodeInfo*) casts? They don’t seem to be needed…

2) Can we convert the NS_ENSURE_ARG into an NS_ASSERTION instead of just removing it?

3) Why NS_ERROR_NO_INTERFACE?

]]>